-
Notifications
You must be signed in to change notification settings - Fork 1.6k
update markdownlint headers to match doc #15360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
Hi @rashmi43. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@rashmi43 Thanks for this, but the issue in question was asking to change the engine we use, not the configuration for the current one. The change youve proposed would actually break every doc in istio.io, as they would all expect to start with a single |
thanks for your comments, how can I go about engine change? |
You would need to learn how the current script/build tools use the Ruby version of markdownlint, update them to package and use the Node.JS version, and then update the configuration to match our existing rules. You may also need to do a mass update of the docs to fix any behaviour we can't configure around. If you are interested in doing this, then consider dropping by #docs on the Istio slack. |
sure I will take this up |
Description
Fixes: #15148
Reviewers