Issue 14989 - Redirect any "v.XX" not including docs to "latest" using a netlify edge function

[sbegin0]

Description

Utilizing netlify edge functions, this is an initial attempt at redirecting old versions to "/latest" (excluding docs).

Reviewers

• Ambient
• Docs
• Installation
• Networking
• Performance and Scalability
• Extensions and Telemetry
• Security
• Test and Release
• User Experience
• Developer Infrastructure
• Localization/Translation

[istio-testing]

Hi @sbegin0. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[craigbox]

/ok-to-test

[craigbox]

spot testing:

loads

• https://deploy-preview-16378--preliminary-istio.netlify.app/
• https://deploy-preview-16378--preliminary-istio.netlify.app/latest/
• https://deploy-preview-16378--preliminary-istio.netlify.app/latest/docs/
• https://deploy-preview-16378--preliminary-istio.netlify.app/archive/

redirects

• https://deploy-preview-16378--preliminary-istio.netlify.app/v1.24

• https://deploy-preview-16378--preliminary-istio.netlify.app/v1.10

• https://deploy-preview-16378--preliminary-istio.netlify.app/v0.1

• https://deploy-preview-16378--preliminary-istio.netlify.app/v1.24/blog/

fails:

• https://deploy-preview-16378--preliminary-istio.netlify.app/v1.24/docs/ (HTTP 508)

HTTP 508 is Loop Detected.

$ curl -D- https://deploy-preview-16378--preliminary-istio.netlify.app/v1.24/docs
HTTP/2 301 
date: Thu, 03 Apr 2025 22:47:58 GMT
location: https://deploy-preview-16378--preliminary-istio.netlify.app/docs
server: Netlify
strict-transport-security: max-age=31536000; includeSubDomains; preload
x-nf-request-id: 01JQYXDX9FAVA8M6TYKED5PQ5D
x-robots-tag: noindex
content-length: 0

curl -D- https://deploy-preview-16378--preliminary-istio.netlify.app/v1.24/docs/
HTTP/2 508 
date: Thu, 03 Apr 2025 22:47:54 GMT
server: Netlify
strict-transport-security: max-age=31536000; includeSubDomains; preload
vary: Accept-Encoding
x-nf-request-id: 01JQYXDSJWSD0T5K3BD737YKAH
x-robots-tag: noindex
content-length: 0

[craigbox]

Have a look at all the things you load when you go to https://istio.io/v1.24/docs/ for example:

/css
/js
/image
/manifest.json
/favicons

While most of these should be the same between releases, we can't currently guarantee that.

https://istio.io/latest/en/sitemap.xml lets you infer the paths that are relevant on the site. They are basically:

/latest/
/latest/about/
/latest/blog/
/latest/docs/
/latest/get-involved/
/latest/news/
/latest/search/

so instead of saying "only allow /docs/ through" I think it would be best to say "if the URL starts with /vX.XX and then one of /, /about, /blog etc then redirect".

[craigbox]

(We also have to account for language codes, currently /zh and /uk.)

[sbegin0]

New fails:
any redirects with just version number and nothing after
https://deploy-preview-16378--preliminary-istio.netlify.app/v1.10

But does redirect anything with '/' after the version number
https://deploy-preview-16378--preliminary-istio.netlify.app/v1.10/

Still fails:
https://deploy-preview-16378--preliminary-istio.netlify.app/v1.24/docs/

[craigbox]

Are you blocked on this, or are you debugging it?

[sbegin0]

Still debugging, should have another commit later today.

[craigbox]

Created #16404 to address how people will get to these archive pages when we remove the general site archive.

[craigbox]

any redirects with just version number and nothing after
https://deploy-preview-16378--preliminary-istio.netlify.app/v1.10

But does redirect anything with '/' after the version number
https://deploy-preview-16378--preliminary-istio.netlify.app/v1.10/

Both now redirect to https://deploy-preview-16378--preliminary-istio.netlify.app/latest/.

Some of my other tests:

• https://deploy-preview-16378--preliminary-istio.netlify.app/v1.24 => /
• https://deploy-preview-16378--preliminary-istio.netlify.app/v1.10 => /latest
• https://deploy-preview-16378--preliminary-istio.netlify.app/v0.1 => /

Can you explain why the results are different? This suggests a subtle bug?

[craigbox]

Language spot testing:

• https://deploy-preview-16378--preliminary-istio.netlify.app/v1.24/zh => does not redirect
• https://deploy-preview-16378--preliminary-istio.netlify.app/v1.24/zh/ => /latest/zh/

When on https://deploy-preview-16378--preliminary-istio.netlify.app/v1.24/zh/docs/overview/ if I hit "English" in the footer I end up at /latest//docs/overview/ (note two slashes, incorrect version.

(I'm not sure how those footer links work)

It feels like we need to build a test suite!

[sbegin0]

^ fixed trailing slash issue but redirects between languages still add that second slash. Working on a fix.