Skip to content

Add DocSearch v3 Integration #16394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add DocSearch v3 Integration #16394

wants to merge 4 commits into from
+43 −23

Conversation

AdeshGhadage
Copy link
Contributor

Description

integrated algolia for site search

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@AdeshGhadage AdeshGhadage requested a review from a team as a code owner April 8, 2025 11:51
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Apr 8, 2025
@istio-testing
Copy link
Contributor

Hi @AdeshGhadage. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Arhell
Arhell reviewed Apr 9, 2025
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Apr 9, 2025
@craigbox
Copy link
Contributor

craigbox commented Apr 9, 2025

You're about 10 steps ahead here, @AdeshGhadage!

  1. results are not yet scoped to versions
Screenshot 2025-04-09 at 4 33 46 PM
  1. The default UI looks out of place on the page; we should retain the single magnifying glass in the first instance.

@craigbox craigbox added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 9, 2025
@AdeshGhadage
Copy link
Contributor Author

when i test docsearch implmentation locally it was not showing any results. i didn't get whats the issue i want to test it in Deploy Preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/user experience do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdeshGhadage @istio-testing @craigbox @Arhell @istio-policy-bot