-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Introduce an interstitial for selecting install mode #16426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
We reviewed the PR during the WG meeting and agreed this is a good step towards where we wanted to go. One suggestion: perhaps list ambient first before sidecars since this is quick start? |
I reviewed the video and ultimately agree with Ian/Keith that we should ultimately make this decision for people.
I agree with the reasoning @jshaughn but It's traditionally hard to explain "sidecarless" without explaining what "sidecar" is. I'll give it a go. |
(I don't know if you missed it when you were previewing Lin, but this page is now linked from "Try Istio" on every page.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor formatting nit just to make it a little easier to read in the future. Otherwise this lgtm. Will wait for @linsun's input before approving.
In general, **we recommend that new users start with ambient mode**. It is faster, cheaper, and easier to manage. There are [advanced use cases](/docs/overview/dataplane-modes/#unsupported-features) that still require the use of sidecar mode, but closing these gaps is on our 2025 roadmap. | ||
|
||
<div style="display: flex; justify-content: center; align-items: center; gap: 1rem;"> | ||
<a href="/docs/ambient/getting-started" class="btn btn--secondary" id="get-started-ambient">Get started with ambient mode</a><a href="/docs/setup/getting-started" class="btn btn--secondary" id="get-started-sidecar">Get started with sidecar mode</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a href="/docs/ambient/getting-started" class="btn btn--secondary" id="get-started-ambient">Get started with ambient mode</a><a href="/docs/setup/getting-started" class="btn btn--secondary" id="get-started-sidecar">Get started with sidecar mode</a> | |
<a href="/docs/ambient/getting-started" class="btn btn--secondary" id="get-started-ambient">Get started with ambient mode</a> | |
<a href="/docs/setup/getting-started" class="btn btn--secondary" id="get-started-sidecar">Get started with sidecar mode</a> |
Oh, I forgot; the CSS is completely horrible on mobile. We need to address that before merging! |
I added back the DNM pending that and will refrain from review. |
The main CTA on istio.io is "Try Istio", which takes people straight into the sidecar documentationn.
This PR introduces an interstitial, which explains both modes, linking to the full description, and then asks you to click a button to choose.
This introduces friction that ultimately we have tried very hard to avoid.
Alternatives considered
Taking people straight into the ambient setup guide is probably a choice the project should make when we have closed some of the gaps on the 2025 roadmap.