Issue 16404 - Documentation version selector dropdown #16478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/L
craigbox
reviewed
May 12, 2025
data/versions.yml
Outdated
| preliminary: "1.27" | ||
|
|
||
| # List of all versions to be included in the dropdown selector and for archive logic | ||
| versions: |
There was a problem hiding this comment.
I think you can infer all of this programatically.
We know what the version is, we can subtract N from it, and when the site is built, it's built with a flag showing if content is archive, preliminary or current. (At least that used to be true; we can just infer anything that is not latest is archive.)
sbegin0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tests a version selector dropdown under "Documentation" and includes previous logic for implementing a netlify edge function.
Reviewers