Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate istio/api cross-repo file generation #2172

Merged
merged 2 commits into from
Dec 14, 2019
Merged

Automate istio/api cross-repo file generation #2172

merged 2 commits into from
Dec 14, 2019

Conversation

clarketm
Copy link
Member

@clarketm clarketm commented Dec 4, 2019 •
edited
Loading

This runs make gen and generates a PR to istio/client-go and istio/istio on postsubmit of istio/api for branches master and release-1.4.

fix #2103

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Dec 4, 2019
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 4, 2019
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 4, 2019
clarketm
clarketm commented Dec 4, 2019
View reviewed changes
@clarketm clarketm force-pushed the api-update branch 7 times, most recently from 6f56c11 to 813cfbc Compare December 4, 2019 06:44
@clarketm clarketm marked this pull request as ready for review December 4, 2019 06:47
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Dec 4, 2019
@clarketm clarketm added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Dec 6, 2019
This was referenced Dec 9, 2019
Merged
Closed
@clarketm clarketm mentioned this pull request Dec 12, 2019
Open
@clarketm clarketm force-pushed the api-update branch 2 times, most recently from ac23ef8 to 5cc7848 Compare December 12, 2019 19:45
@clarketm clarketm requested review from fejta and howardjohn December 12, 2019 19:56
howardjohn
howardjohn approved these changes Dec 12, 2019
View reviewed changes
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Dec 12, 2019
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@clarketm clarketm added the do-not-merge Block automatic merging of a PR. label Dec 12, 2019
@clarketm
Copy link
Member Author

clarketm commented Dec 12, 2019 •
edited
Loading

fejta
fejta approved these changes Dec 14, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@istio-testing istio-testing added the do-not-merge/hold Block automatic merging of a PR. label Dec 14, 2019
@clarketm clarketm removed do-not-merge Block automatic merging of a PR. do-not-merge/hold Block automatic merging of a PR. labels Dec 14, 2019
@istio-testing istio-testing merged commit 76cbd3f into istio:master Dec 14, 2019
@istio-testing
Copy link
Collaborator

@clarketm: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key istio.api.master.gen.yaml using file prow/cluster/jobs/istio/api/istio.api.master.gen.yaml

In response to this:

This runs make gen and generates a PR to istio/client-go and istio/istio on postsubmit of istio/api for branches master and release-1.4.

fix #2103

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@clarketm clarketm deleted the api-update branch February 13, 2020 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@fejta fejta fejta approved these changes

@Katharine Katharine Awaiting requested review from Katharine

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees

@howardjohn howardjohn

@michelle192837 michelle192837

@fejta fejta

@cjwagner cjwagner

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate istio/api cross-repo file generation and propagation
8 participants
@clarketm @istio-policy-bot @istio-testing @howardjohn @fejta @michelle192837 @cjwagner @googlebot