CI: fix build-windows by removing hardcoded VS 2022 CMake generator#847
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job build-windows
CI: fix build-windows by removing hardcoded VS 2022 CMake generator
Jul 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Windows CI job in libhv to avoid pinning a specific Visual Studio CMake generator, so the workflow keeps working as windows-latest images move to newer Visual Studio versions.
Changes:
- Remove
-G "Visual Studio 17 2022"from the Windows CMake configure step and rely on CMake’s default generator detection. - Keep
-A x64and existing build/test commands intact.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows-latestnow resolves towindows-2025-vs2026(VS 2026), which no longer includes VS 2022, causing CMake to fail withGenerator "Visual Studio 17 2022" could not find any instance of Visual Studio.Change
-G "Visual Studio 17 2022"from thecmakeinvocation; CMake will auto-detect the installed VS version.-A x64is retained to preserve the x64 architecture target.