chore(ameba): Do not exclude /api routes from Lint/UselessAssign - #5900
chore(ameba): Do not exclude /api routes from Lint/UselessAssign#5900Fijxu wants to merge 1 commit into
Conversation
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Ameba configuration changes the ChangesLint configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.9).ameba.yml2026-08-06 22:55:18,150 [MainThread ] [ERROR] Failed to invoke function /usr/local/lib/python3.11/site-packages/checkov/common/runners/runner_registry._parallel_run with (<checkov.secrets.runner.Runner object at 0x7f2a0f9a0a50>, None, None, ['.ameba.yml'], <checkov.runner_filter.RunnerFilter object at 0x7f2a0f973d50>, True, None) ... [truncated 365 characters] ... mkdir(file, 0o700) Comment |
Checklist
AI Disclosure
Model(s) used (and thinking/reasoning level if relevant):
Tool(s) used:
How was AI used?
Pull request description
Routes bellow files under
src/invidious/routes/are used to render ECR, and they can take variables from the functions, they appear as unused variables for Ameba, but they are used in the ECR files as the comments says, but it also excluded thesrc/invidious/routes/apifiles, which are used for the API and do not render any ECR, so useless assigns insrc/invidious/routes/apifiles can be safely removed.Summary by CodeRabbit