Skip to content

chore: removed unused locale argument in #get_about_info function - #5902

Open
Fijxu wants to merge 1 commit into
iv-org:masterfrom
Fijxu:remove-unused-arg
Open

chore: removed unused locale argument in #get_about_info function#5902
Fijxu wants to merge 1 commit into
iv-org:masterfrom
Fijxu:remove-unused-arg

Conversation

@Fijxu

@Fijxu Fijxu commented Aug 5, 2026

Copy link
Copy Markdown
Member

Checklist

  • I have read the AI Policy and understand the disclosure requirements

AI Disclosure

  • AI was not used to create this pull request
  • AI was used to fully create this pull request
  • AI was used to partially create this pull request

Model(s) used (and thinking/reasoning level if relevant):

Tool(s) used:

How was AI used?


Pull request description

Title, unused arg.
Related to #5898

Summary by CodeRabbit

  • Bug Fixes
    • Improved channel information retrieval across API and web routes.
    • Resolved inconsistencies when loading channel details with localized requests.
    • Existing error handling and responses remain unchanged.

Greptile Summary

This change removes the unused locale argument from the channel about-information helper and updates its API and web route callers. The updated signature and both tracked call sites are consistent, and the removed parameter was not referenced by the helper body.

T-Rex validation blocked

The focused make verify compile check could not run because the required Crystal and Shards tools are not installed; Docker is also unavailable for the container fallback.

Confidence Score: 5/5

No defect was found in the edited helper signature or its two updated callers.

There are no final review findings. Source inspection confirmed the removed parameter was unused and that the tracked callers match the new one-argument signature.

Files Needing Attention: No files need author attention. A Crystal-enabled environment should run make verify before release because compilation could not be exercised here.

T-Rex T-Rex Logs

What T-Rex did

  • Ran make verify to validate the Crystal build step; the build failed because Crystal was not installed, exiting with code 2 and an underlying status of 127.
  • Compared the helper and its callers before and after the change; observed that locale was unused in the helper body and that every tracked caller uses the matching one-argument signature.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "chore: removed unused `locale` argument ..." | Re-trigger Greptile

@TheFrenchGhosty

Copy link
Copy Markdown
Member

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The get_about_info method now accepts only a channel ID. The API and web channel routes no longer pass a locale argument. Existing error handling remains unchanged.

Changes

Channel locale parameter cleanup

Layer / File(s) Summary
Update channel lookup contract and callers
src/invidious/channels/about.cr, src/invidious/routes/api/v1/channels.cr, src/invidious/routes/channels.cr
get_about_info now accepts only ucid. Both channel routes call it without locale.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the unused locale argument from get_about_info.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@TheFrenchGhosty

Copy link
Copy Markdown
Member

@greptileai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants