Adding Favorites to Exported Bookmarks#33
Open
vincemonte wants to merge 5 commits intoivnvxd:mainfrom
Open
Conversation
…he recursive child search. Assigned a new favorites folder to the results and appended to the front of the bookmarks. Removed bookmarks count, will add back in later commit.
… to implement with current system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32: Export Arc favorites to bookmarks
As reported in issue #32 by @webserviceXXL, Arc's favorites (pinned items that exist across all spaces) were not being exported. This PR adds support for exporting them into a "Favorites" folder at the top of the bookmarks hierarchy.
Additional changes:
build_bookmark_entry()andbuild_folder_entry()functions to reduce code duplication