Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new architecture support #2033

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alanjhughes
Copy link

@alanjhughes alanjhughes commented Mar 7, 2024

Adds support for the new architecture with bridgeless enabled which will be the default in 0.74

Tested on

  • OId Arch ✅
  • New Arch
    • Bridgeless enabled
      • iOS ✅
      • Android ✅
    • Bridgeless disabled ✅
      • iOS ✅
      • Android ✅

Note: On Android, onActivityResult was not implemented in RN 0.74 RC2 on bridgeless. It will be added in RC3. I have already tested against this change and it works as expected
Issues have been resolved in RC3 and now everything works correctly

@brentvatne
Copy link

looking forward to this landing and getting us one step closer to new arch support in the ecosystem! @ivpusic any chance you could merge this and get it into a new release, so that we can include it in a list of libraries supported in the new arch for react-native 74?

@brentvatne
Copy link

@ivpusic - any chance you can land this?

@eeston
Copy link

eeston commented Oct 25, 2024

Is this PR still mergable or is it stale?

@dcenatiempo
Copy link

dcenatiempo commented Nov 4, 2024

@ivpusic

Can this please get merged?

Preventing us from updating to RN 76

@Maker-Mark
Copy link

@ivpusic Any ETA on getting this merged?

@jsheffers
Copy link

Would love this!

@Arjit0762
Copy link

Please merge this one.. Needed

@ubaidkolad
Copy link

Please get this merged, blocked to update to RN 0.76

@breezertwo
Copy link

Please get this merged. Only package preventing us from updating:
Unsupported on New Architecture: react-native-image-crop-picker

@brentvatne
Copy link

@breezertwo - in the meantime, you could consider migrating to expo-image-picker if the features there meet your requirements. at expo we opened this pr to help this library back in may but it may just be that the maintainer doesn't have time to dedicate to it anymore.

@ivpusic
Copy link
Owner

ivpusic commented Jan 15, 2025

I can confirm that I am currently short on time. @brentvatne have you done some testing on your side for this PR, or somebody else? does everything seems to be fine with the ios and android?

@alanjhughes could you take a look into merge conflict?

@alanjhughes
Copy link
Author

@ivpusic the PR is old now so I'll look at bringing it up to date

@ponikar
Copy link

ponikar commented Jan 24, 2025

Looking forward to have support for new architecture. If this PR is not stale.

@dretsa
Copy link

dretsa commented Jan 27, 2025

It's been two weeks, have you had a chance to look at it @alanjhughes? It's a popular package and I'm sure the community would love support for the new architecture. Is there any way I could help with this? I am not great with Swift or Kotlin but can help testing (maybe even coding with some guidance).

@Arjit0762
Copy link

Please upgrade it to new architecture @alanjhughes

@PHtorres
Copy link

We should update the React Native Directory when this PR is good to go: https://reactnative.directory/?newArchitecture=true

@moealien
Copy link

Excited for this to be merged.....
other rn image pickers arent as configurable

@ubaidkolad
Copy link

Any update on this? This is the only package blocking us from updating to new arch. I couldn't find a replacement for this library yet.

@jerrywonderr
Copy link

Please, when will this be merged? I am about to move to the old architecture just because of this.

@RenatoFerracini
Copy link

I really need this too!

@blackirishmec
Copy link

Interested in this!

@jsheffers
Copy link

jsheffers commented Mar 21, 2025

Closed the pull request due to not being able to build this version at all...

@RenatoFerracini
Copy link

@jsheffers Oh really? I was trying to test your version but I couldn't build it either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.