-
-
Notifications
You must be signed in to change notification settings - Fork 232
feat: add Alpine image #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
feat: add Alpine image #1949
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
735835d
add alpine image
pat-s d481755
lint
pat-s cc275c0
chore: address review
pat-s 42539ef
Potential fix for pull request finding
pat-s 5cabc06
Update Dockerfile
pat-s 87ec282
Potential fix for pull request finding
pat-s eee1f2e
fix(docker): use absolute path for alpine entrypoint
pat-s 233a2b8
feat(docker): add curl to alpine image
pat-s 0457262
fix(docker): register QEMU for arm64 alpine build and fix verify exam…
pat-s ac73e8d
fix(docker): gate QEMU setup on alpine leg and clarify image verifica…
pat-s File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,20 @@ RUN cp target/$(cat rust_target.txt)/dist/prek /prek | |
| # TODO: Optimize binary size, with a version that also works when cross compiling | ||
| # RUN strip --strip-all /prek | ||
|
|
||
| FROM scratch | ||
| FROM alpine:3.24 AS alpine | ||
| RUN apk add --no-cache \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Containerized hooks are also quite common. Would it make sense to add |
||
| ca-certificates \ | ||
| curl \ | ||
| git \ | ||
| nodejs \ | ||
| npm \ | ||
| python3 \ | ||
| py3-pip | ||
| COPY --from=build /prek /usr/local/bin/prek | ||
| WORKDIR /io | ||
| ENTRYPOINT ["/usr/local/bin/prek"] | ||
|
|
||
| FROM scratch AS minimal | ||
| COPY --from=build /prek / | ||
| WORKDIR /io | ||
| ENTRYPOINT ["/prek"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.