You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not necessarily opposed to this, but I do have one concern.
In general, I think of named errors as existing because the caller is going to do something based on the type of error. But as far as I can tell, all of these errors are actually caller bugs. In that case, I don't see why the caller would check for them. If they happen the caller should be changed so they never occur.
I'm not necessarily opposed to this, but I do have one concern.
In general, I think of named errors as existing because the caller is going to do something based on the type of error. But as far as I can tell, all of these errors are actually caller bugs. In that case, I don't see why the caller would check for them. If they happen the caller should be changed so they never occur.
But perhaps I'm missing some use case...
I encountered a case while processing a Batch where I wanted to check if it had finished. I couldn't use errors.Is for the comparison because a new error instance was created each time. It seems to me it would be better to iterate over the array of Batch responses rather than the original input array, since we are dealing with database behavior rather than user data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added predifined errors for batch funcs to consume them with errors.Is.