fix(doubao): support current history and detail DOM#1375
Open
lmmsoft wants to merge 2 commits into
Open
Conversation
Generated on: cmcc-i5 Generated by: home_codex
There was a problem hiding this comment.
Pull request overview
This PR updates the Doubao CLI adapter’s DOM-scraping scripts so history and detail can continue working with Doubao’s current sidebar and conversation detail markup.
Changes:
- Broadened sidebar selectors in
getConversationListScript()to handle current conversation anchors and dedupe results. - Broadened detail selectors in
getConversationDetailScript()to handle current message containers/bubbles. - Added/extended unit tests to assert the updated selector coverage, and exported the scripts via
__test__for testing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| clis/doubao/utils.js | Updates the in-page evaluation scripts for conversation list + detail extraction, and exports the new scripts for tests. |
| clis/doubao/utils.test.js | Adds tests asserting the updated DOM selectors are present in the generated scripts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Generated on: cmcc-i5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#flow_chat_sidebar,conversation_*anchors, and/chat/<id>links).flow-markdown-bodycontentVerification
PATH=/Users/lmm333/.nvm/versions/node/v24.13.0/bin:$PATH npm exec vitest run --project adapter clis/doubao/utils.test.js clis/doubao/history.test.js clis/doubao/detail.test.jsPATH=/Users/lmm333/.nvm/versions/node/v24.13.0/bin:$PATH npm run typecheckopencli doubao history --limit 5returns real conversations andopencli doubao detail <conversation_id>returns user/assistant messages