Skip to content

fix(facebook/feed): add fallback extraction for empty article nodes#1538

Merged
jackwener merged 3 commits into
jackwener:mainfrom
GreyC:pr/facebook-feed-empty-fallback
May 14, 2026
Merged

fix(facebook/feed): add fallback extraction for empty article nodes#1538
jackwener merged 3 commits into
jackwener:mainfrom
GreyC:pr/facebook-feed-empty-fallback

Conversation

@GreyC
Copy link
Copy Markdown
Contributor

@GreyC GreyC commented May 13, 2026

Summary

  • add a fallback extraction path when Facebook feed article nodes are present but empty
  • preserve the existing primary article extraction path
  • add focused test coverage for the fallback shape

Fixes #1533.

Verification

  • npx vitest run --project adapter clis/facebook/feed.test.js
  • npm run typecheck

GreyC and others added 2 commits May 14, 2026 18:30
Add fallback extraction for Facebook feed posts when [role=article] nodes exist but contain empty text. Includes diagnostic errors, content/author cleanup, nested-container dedupe, and an evaluate-script syntax regression test.
@jackwener jackwener force-pushed the pr/facebook-feed-empty-fallback branch from 5cc18ea to eba7698 Compare May 14, 2026 10:32
@jackwener jackwener merged commit 300607f into jackwener:main May 14, 2026
11 checks passed
@GreyC GreyC deleted the pr/facebook-feed-empty-fallback branch May 14, 2026 13:15
GreyC pushed a commit to GreyC/OpenCLI that referenced this pull request May 14, 2026
Captures conventions the upstream maintainer enforces by amending PRs
before merging (observed across jackwener#1538-jackwener#1542): typed errors, fail-fast
arg validation, imperative func over pipeline, JSON.parse type guards,
merge-then-filter, scored Array.find replacement, stale socket guards,
error-path tests, lifecycle docs, manifest rebuild.

Claude Code auto-loads CLAUDE.md; AGENTS.md points other AI tools to it.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] facebook feed can miss posts when article nodes are empty

2 participants