Bug-fix/photo reaction detection#103
Merged
markkrumholz merged 87 commits intoJul 10, 2026
Merged
Conversation
XRByte
marked this pull request as ready for review
July 2, 2026 12:13
markkrumholz
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101 and #102
The previous photo reaction detection mechanism was only able to detect prizmo reactions and some krome reacrtions. The mechanism was loose and didn't depend on the reactants but on the rates containing a single "photo" string which is inconsistent with other reaction formats. A proper "non patchy" implementation was required for which required a fundamental architectural change. The changes are as follows:
_<specie>. The choice of a_doesn't break any code generation capabilities.A -> B + CandA + B -> Cwill be indistinguishable. The new serialization format implemented isA.B__C.Dwhere reactants and products are separated by.and either side is separated by__.species.coreandspecies.special. However, network.species only contain the core species to avoid further cascade of problems.