Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sort methods for metamodel attributes are missing from the Path attributes for when the NavigableAttribute pattern is used. This PR looks into adding them by having the navigate(*Attribute) methods now return *Attribute. To do that, the respective *Path classes are switched to be a *Attribute rather than only a *Expression. With these changes, you can now get a
.name()from the path classes likeNumericPath, and because it now inheritsNumericAttributerather than justNumericExpression, we also get the defaultasc()anddesc()methods that are based on thename(). The same is true for the other sortable types, and withTextPath, we also inherit the default IgnoreCase variants of the asc/desc methods.I added a unit test with navigation to each of the path types, demonstrating that Sorts are now successfully obtained.