Add Published and PublishedOn attributes to template objects #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamErde
approved these changes
Dec 11, 2024
|
|
||
| [CmdletBinding(SupportsShouldProcess)] | ||
| param ( | ||
| [parameter(Mandatory, ValueFromPipeline)] |
There was a problem hiding this comment.
Accepting values from the pipeline requires a process {} block. The begin and end blocks are optional, but process is required to bind to the pipeline object.
| Set-AdditionalTemplateProperty -ADCSObjects $ADCSObjects -ForestGC 'dc1.ad.dotdot.horse:3268' | ||
| #> | ||
|
|
||
| [CmdletBinding(SupportsShouldProcess)] |
There was a problem hiding this comment.
This function should ideally either suppress the PSScriptAnalyzer check for SupportsShouldProcess or actually wrap the set/add action in a ShouldProcess block. Because (IIRC) this is modifying a transient object within the script and not a system object, you're probably good to just suppress the check and not build in support for ShouldProcess in this function.
SamErde
reviewed
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly assess the risk presented by a single finding, Locksmith must know if the template is available for enrollment on one or more CAs. This is support of #117.