fix: personality LLM now respects the selected refinement model#712
fix: personality LLM now respects the selected refinement model#712aajinn wants to merge 1 commit into
Conversation
The 'Speak in character' rewrite (POST /generate with personality=true)
and Compose (POST /profiles/{id}/compose) both bypassed the user's
llm_model selection from capture_settings, always loading Qwen3 0.6B
instead of the chosen 1.7B/4B model.
Both routes now read saved.llm_model from capture_settings and pass it
as model_size to the personality service functions.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR wires personality-driven features to respect the user-configured LLM model setting. The ChangesPersonality LLM Model Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bug: Personality LLM (Speak in character / Compose) always loaded Qwen3 0.6B regardless of the user's refinement model selection
Summary by CodeRabbit