Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #94 - Refactor TelephoneBook #95

Open
wants to merge 1 commit into
base: solutions/maps/01
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions Exercise.java
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
import java.util.HashMap;

public class Exercise {

public static void main(String[] args) {
TelephoneBook telephoneBook = new TelephoneBook();
TelephoneBook telephoneBook = new TelephoneBook(new HashMap<>());

telephoneBook.addEntry(
new TelephoneBook.Person("Hans Maier"),
new TelephoneBook.TelephoneNumber("+49 67234 887261"));
new Person("Hans Maier"),
new TelephoneNumber("+49 67234 887261"));
telephoneBook.addEntry(
new TelephoneBook.Person("Peter Mueller"),
new TelephoneBook.TelephoneNumber("+49 7529 87612"));
new Person("Peter Mueller"),
new TelephoneNumber("+49 7529 87612"));
telephoneBook.addEntry(
new TelephoneBook.Person("Lisa Schmidt"),
new TelephoneBook.TelephoneNumber("+49 8762 52081"));
new Person("Lisa Schmidt"),
new TelephoneNumber("+49 8762 52081"));

System.out.println(telephoneBook.getTelephoneNumberByName("Hans Maier"));
}
2 changes: 2 additions & 0 deletions Person.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
public record Person(String name) {
}
33 changes: 13 additions & 20 deletions TelephoneBook.java
Original file line number Diff line number Diff line change
@@ -1,24 +1,17 @@
import java.util.HashMap;
import java.util.Map.Entry;
import java.util.Map;

public class TelephoneBook {
public record TelephoneBook(HashMap<Person, TelephoneNumber> entries) {
public void addEntry(Person person, TelephoneNumber telephoneNumber) {
entries.put(person, telephoneNumber);
}

private HashMap<Person, TelephoneNumber> entries = new HashMap<>();

public void addEntry(Person person, TelephoneNumber telephoneNumber) {
entries.put(person, telephoneNumber);
}

public TelephoneNumber getTelephoneNumberByName(String name) {
for (Entry<Person, TelephoneNumber> entry : entries.entrySet()) {
if (entry.getKey().name().equals(name)) {
return entry.getValue();
}
}
return null;
}

public record Person(String name) {}

public record TelephoneNumber(String value) {}
public TelephoneNumber getTelephoneNumberByName(String name) {
for (Map.Entry<Person, TelephoneNumber> entry : entries.entrySet()) {
if (entry.getKey().name().equals(name)) {
return entry.getValue();
}
}
return null;
}
}
2 changes: 2 additions & 0 deletions TelephoneNumber.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
public record TelephoneNumber(String number) {
}