Skip to content

visit_by Implementation #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

visit_by Implementation #2939

wants to merge 21 commits into from

Conversation

MalithaPrabhashana
Copy link
Collaborator

Description

@MalithaPrabhashana MalithaPrabhashana linked an issue Sep 30, 2025 that may be closed by this pull request
Implement visit by jaseci-labs/Agentic-AI#245
Open
@MalithaPrabhashana MalithaPrabhashana self-assigned this Sep 30, 2025
Thamirawaran
Thamirawaran reviewed Oct 1, 2025
View reviewed changes
Thamirawaran
Thamirawaran reviewed Oct 1, 2025
View reviewed changes
Thamirawaran
Thamirawaran requested changes Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@Thamirawaran Thamirawaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make those changes

ThakeeNathees
ThakeeNathees requested changes Oct 6, 2025
View reviewed changes
ThakeeNathees
ThakeeNathees requested changes Oct 6, 2025
View reviewed changes
@Jayanaka-98 Jayanaka-98 self-requested a review October 8, 2025 12:36
Jayanaka-98
Jayanaka-98 requested changes Oct 8, 2025
View reviewed changes
Copy link
Collaborator

@Jayanaka-98 Jayanaka-98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some conflicts we need to take care of.

Need testcases for byllm, we can use the mockllm technique used in other tests, to return an index list which allows the downstream work of visit by work.

@Jayanaka-98 Jayanaka-98 mentioned this pull request Oct 8, 2025
Closed
@MalithaPrabhashana
Copy link
Collaborator Author

Ohh that's great. I'll check on it

@MalithaPrabhashana MalithaPrabhashana changed the title [Draft] visit_by Implementation visit_by Implementation Oct 9, 2025
Jayanaka-98
Jayanaka-98 approved these changes Oct 9, 2025
View reviewed changes
Copy link
Collaborator

@Jayanaka-98 Jayanaka-98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are sufficient for now. We can develop it from here.

@Jayanaka-98
Copy link
Collaborator

An Issue for adding docs for this feature should be included

Jayanaka-98
Jayanaka-98 requested changes Oct 9, 2025
View reviewed changes
Copy link
Collaborator

@Jayanaka-98 Jayanaka-98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add release notes

@Jayanaka-98 Jayanaka-98 self-requested a review October 9, 2025 12:13
@MalithaPrabhashana
Copy link
Collaborator Author

Release notes added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Thamirawaran Thamirawaran Thamirawaran requested changes

@ThakeeNathees ThakeeNathees ThakeeNathees approved these changes

@Jayanaka-98 Jayanaka-98 Jayanaka-98 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@MalithaPrabhashana MalithaPrabhashana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement visit by

4 participants

@MalithaPrabhashana @Jayanaka-98 @ThakeeNathees @Thamirawaran