-
Notifications
You must be signed in to change notification settings - Fork 328
rm defusepass.py
#3038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kugesan1105
wants to merge
24
commits into
main
Choose a base branch
from
rm_defuse
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
rm defusepass.py
#3038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used DefUsePass import and enhance semantic analysis with additional context checks
|
kugesan1105
commented
Oct 14, 2025
Comment on lines
651
to
668
# handle member access | ||
# pyright handle this in getDeclInfoForNameNode() | ||
if isinstance(node_.parent, uni.AtomTrailer) and node_.parent.parent | ||
and isinstance(node_.parent.parent, uni.Assignment) { | ||
|
||
if node_.parent.parent.type_tag is not None { | ||
annotation_type = self.get_type_of_expression( | ||
node_.parent.parent.type_tag.tag | ||
); | ||
return self._convert_to_instance(annotation_type); | ||
} | ||
|
||
else { # Assignment without a type annotation: obj.member = <expr> | ||
if node_.parent.parent.value is not None { | ||
return self.get_type_of_expression(node_.parent.parent.value); | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…lution in type evaluator
…ce when resolving imported symbols
…meters method in TypeEvaluator
|
…ons in reference test cases
…y and consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description