Enhance CoverDevice with automatic command type detection #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the CoverDevice class by adding automatic detection of command types, allowing it to work with devices that use either "open"/"close" or "on"/"off" commands without manual configuration.
- Added lazy command type detection that checks device status on first use
- Implemented manual override method
set_cover_command_type()for explicit control - Updated documentation and added usage examples
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tinytuya/core/core.py | Version bump from 1.17.4 to 1.17.5 |
| tinytuya/CoverDevice.py | Added command detection logic, manual override method, and updated function signatures |
| RELEASE.md | Added release notes for v1.17.5 describing the new CoverDevice features |
| README.md | Updated CoverDevice documentation and added comprehensive usage examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tomatic type identification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds automatic detection of the command type used by
CoverDevice("open"/"close" vs "on"/"off"), improving compatibility with different device models and reducing the need for manual configuration. It includes a manual override method, updates documentation and examples, and bumps the project version.CoverDevice command detection and configuration:
CoverDeviceto automatically determine whether to use "open"/"close" or "on"/"off" commands by checking device status on the first use, defaulting to "on"/"off" for backward compatibility (tinytuya/CoverDevice.py).set_cover_command_type(use_open_close=True)method to allow manual override of the detected command type (tinytuya/CoverDevice.py).Documentation and examples:
README.mdto document the new command detection behavior and manual override method (tinytuya/CoverDevice.py,README.md). [1] [2]README.mddemonstrating how to useCoverDevicewith both automatic detection and manual override (README.md).Closes #653