Skip to content

Conversation

@VascoSingh
Copy link
Contributor

No description provided.

Copy link
Owner

@jasonhedman jasonhedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the direction.

Can you put the MagicUI flickering grid behind the loading animation to take up the empty space https://magicui.design/docs/components/flickering-grid

We also have the animated logo component here that is a similar aesthetic and may be more cohesive with the brand: https://github.com/jasonhedman/toolkit.dev/blob/main/src/components/ui/logo/animated/index.tsx

So the strategy would be

  1. animated grid takes up a bunch of space. Use a fixed height to be something like h-48. Then absolutely position the animated logo in the center of that container

Also run pnpm check to catch the lint errors that are failing CI. You will also need to format with pnpm format:write to pass CI as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants