fixes #1681 merge reentrant locks into a single lock and eliminate synchronized blocks #1682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look good to me and solve the #1681 |
brettwooldridge
force-pushed
the
master
branch
from
6527552 to
1d3ceb7
Compare
|
Rebasd on master. |
matthiasblaesing
approved these changes
Sep 21, 2025
There was a problem hiding this comment.
@brettwooldridge thanks for the quick fix and @jjanowsk thanks for testing/verifying.
The change makes sense to me and I don't see anything obviously wrong here, so lets get this in.
|
Thanks @matthiasblaesing for the quick action. Maybe with the MacOS clang issue fixed and all tests passing, maybe we can get a release out soon. |
|
@brettwooldridge release is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validated with user provided test case that exhibited the error after "multiple runs". I have run the test for several thousand iterations on both an Epyc CPU and a dual-CPU Intel enterprise-class server without deadlock.
Note: MacOS build failures are unrelated to this change and have to do with a recent change in the clang compiler. See my related pull request #1683.