Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template [#12] #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
## :pencil: Beskrivelse av problemet

## :information_desk_person: Løsning

## :checkered_flag: Jeg har dekket ny kode med:

- [ ] Tester
- [ ] Dokumentasjon
- [ ] UA-krav
Copy link
Collaborator

@HenrikEide HenrikEide Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veldig bra! 😄 Men! Dersom jeg skulle ha endret noe som helst (ikke at jeg ville gjort det selv, men i en hypotetisk situasjon) så ville jeg vurdert å hatt konsekvent bruk av språk i både tekst og forkortelser! Det kan også hende, helt hypotetisk, at ikke samtlige vet hva UA forkortelsen betyr 😊 På forhånd takk!

Mvh Henrik

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha oki, kan fjernes. hav tenker du om å sjekke om du har testet mobil og nettside?


## :art: Visuelle Endringer

| Før | Etter |
| --- | ----- |
| | |
Copy link
Collaborator

@HenrikEide HenrikEide Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For eksempel screenshots av endringer?

edit: Fikk svar irl, yes