Move the CI actions off Node 20 - #10
Merged
Merged
Conversation
Every action in both workflows targeted Node 20, which the runners now force onto Node 24 with a deprecation warning, and actions/setup-java@v4 is deprecated outright. Bumped to the latest major of each: checkout v7, setup-java v5, upload-artifact v7. Note that upload-artifact v5 would not have been enough — it still defaulted to Node 20; v6 is the first that actually runs on 24. gradle/actions/setup-gradle is the exception, held at v5 rather than v6. v6 extracted the caching into `gradle-actions-caching`, a proprietary component governed by Gradle's Terms of Use instead of the MIT licence. Accepting those terms on behalf of an Apache-2.0 project is a maintainer's decision, not something to slip in with a version bump, and v5 already runs on Node 24 — which is the whole point of this change. The reason is written next to the pin so it does not get "helpfully" bumped later. Nothing here changes behaviour for this repository: checkout v7's fork-PR block applies to pull_request_target and workflow_run, neither of which is used, and upload-artifact v7's direct-upload mode is opt-in. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every action in both workflows targeted Node 20, which the runners now force onto Node 24 with a deprecation warning, and
actions/setup-java@v4is deprecated outright.actions/checkoutactions/setup-javaactions/upload-artifactgradle/actions/setup-gradleupload-artifactv5 would not have been enough: it still defaulted to Node 20, and v6 is the first that actually runs on 24.Why gradle/actions stops at v5
gradle/actions@v6extracted the caching intogradle-actions-caching, a proprietary component governed by Gradle's Terms of Use rather than the MIT licence. Accepting those terms on behalf of an Apache-2.0 project is a maintainer's decision, not something to slip in with a version bump — and v5 already runs on Node 24, which is the entire point of this change. The reason is written next to the pin so it does not get "helpfully" bumped later.If the project does want v6, that is a deliberate call worth making on its own.
No behaviour change here
checkout@v7's fork-PR block applies topull_request_targetandworkflow_run; neither workflow uses either trigger.upload-artifact@v7's direct-upload mode is opt-in via the newarchiveparameter; the default is unchanged.Verified
All 7 jobs green on this branch (JDK 17 and 21 across Linux, macOS and Windows, plus static analysis), and the run produces zero annotations — the Node 20 deprecation notice is gone rather than merely quieter.
🤖 Generated with Claude Code