-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add test of documentation coverage #33316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @jakevdp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial new test designed to automatically enforce documentation coverage for JAX's public API surface. By programmatically identifying both documented and public APIs, this test will help prevent future regressions where new public functions or classes are added without corresponding documentation, ensuring a more complete and up-to-date user guide. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new test to ensure documentation coverage for public APIs, which is a great addition for maintaining the project's quality. The implementation is solid, using file parsing and module introspection to compare public APIs against documented ones. I've made a couple of suggestions to improve the new test file's maintainability and correctness. The documentation updates in other files look good.
62e7a01 to
8115c14
Compare
ba23ec8 to
c188cd3
Compare
c188cd3 to
0b85b2b
Compare
A frequent documentation issue is that we add public APIs without adding them to the appropriate place in the docs. This is a new test that will check this automatically. There are two main pieces:
docsdirectory looking for documentation of various functionsjaxpackage tree looking for public APIsFinally, there is a test that compares these two and errors in the case of undocumented APIs. This script also allows for specification of submodules which should be skipped entirely (to avoid e.g. ImportErrors in cases where optional dependencies are required), as well as particular APIs that are expected to be undocumented.
The test reveals many potential fixes; I will plan to patch-up the documentation as a followup.