Skip to content

Conversation

@jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Nov 13, 2025

A frequent documentation issue is that we add public APIs without adding them to the appropriate place in the docs. This is a new test that will check this automatically. There are two main pieces:

  • a function which crawls the docs directory looking for documentation of various functions
  • a function which crawls the jax package tree looking for public APIs

Finally, there is a test that compares these two and errors in the case of undocumented APIs. This script also allows for specification of submodules which should be skipped entirely (to avoid e.g. ImportErrors in cases where optional dependencies are required), as well as particular APIs that are expected to be undocumented.

The test reveals many potential fixes; I will plan to patch-up the documentation as a followup.

@jakevdp jakevdp self-assigned this Nov 13, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jakevdp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial new test designed to automatically enforce documentation coverage for JAX's public API surface. By programmatically identifying both documented and public APIs, this test will help prevent future regressions where new public functions or classes are added without corresponding documentation, ensuring a more complete and up-to-date user guide.

Highlights

  • New Documentation Coverage Test: A new test (documentation_coverage_test.py) has been added to automatically verify that all public JAX APIs are documented.
  • API Discovery Mechanism: The test includes functions to crawl the docs directory for documented APIs and the jax package for public APIs, then compares them.
  • Configurable Skips: The test allows for specifying submodules to skip entirely and individual APIs that are intentionally undocumented.
  • Documentation Updates: Minor additions were made to jax.nn.initializers.rst and jax.nn.rst to include previously missing API entries, and a docstring was added to the Initializer protocol.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new test to ensure documentation coverage for public APIs, which is a great addition for maintaining the project's quality. The implementation is solid, using file parsing and module introspection to compare public APIs against documented ones. I've made a couple of suggestions to improve the new test file's maintainability and correctness. The documentation updates in other files look good.

@jakevdp jakevdp force-pushed the doc-coverage-test branch 5 times, most recently from 62e7a01 to 8115c14 Compare November 14, 2025 19:01
@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Nov 14, 2025
@jakevdp jakevdp force-pushed the doc-coverage-test branch 3 times, most recently from ba23ec8 to c188cd3 Compare November 14, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pull ready Ready for copybara import and testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant