[mpmd] Fix nanobind compatibility and add OPTIMIZE enum value #33331
+6
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two nanobind issues: 1. Added .none() annotations for optional FragmentInfo parameters (call_counter, split_type) to accept None from Python 2. Changed PartitioningPhase enum to nb::is_flag() for bitmask support, allowing combinations like OPTIMIZE | PARTITION. Seems like otherwise apply_partioning() will error on combinations since they are not explicitly declared enum values. PiperOrigin-RevId: 832290786
copybara-service
bot
force-pushed
the
test_832290786
branch
from
ff87e73 to
92e179a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[mpmd] Fix nanobind compatibility and add OPTIMIZE enum value
Fixes two nanobind issues:
(call_counter, split_type) to accept None from Python
allowing combinations like OPTIMIZE | PARTITION. Seems like otherwise
apply_partioning() will error on combinations since they are not explicitly
declared enum values.