Improve doc about get_process_url. #435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one is for you @WhyNotHugo I'm not sure if this is ours to resolve. |
WhyNotHugo
approved these changes
Feb 11, 2025
|
Hi @WhyNotHugo For curiosity, why you discourage it ? |
|
If we ever need to update the implementation of Maybe we could introduce a setting a custom namespace can be specified, so users don't need to do this re-implementation at all. |
|
Make sense.. I will send a PR with the namespace settings as mentioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the Django Payments documentation by clarifying how to configure URL patterns when using the package inside a namespaced app. It adds a note explaining the need to override
get_process_urlto ensure proper URL resolution. Additionally, it includes an example of how to modifyget_process_urlto include the correct namespace.Why This Matters
Without this clarification, users implementing django-payments within a namespaced app may encounter issues where the
process_paymentURL cannot be resolved.Related Issue
Fixes #396