Skip to content

Update installation doc; phonenumber required. #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update installation doc; phonenumber required. #764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/installation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Add the following apps to the ``INSTALLED_APPS``:
'django_otp.plugins.otp_email', # <- for email capability.
'otp_yubikey', # <- for yubikey capability.
'two_factor',
'two_factor.plugins.phonenumber', # <- for phone number capability.
'two_factor.plugins.phonenumber', # <- Required, even if phone is not used.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is true - I currently use two_factor without the phone number plugin listed in my INSTALLED_APPS: https://codeberg.org/Inboxen/Inboxen/src/commit/e441dd4aece7028b32307b1e7980ff5301a37814/inboxen/settings.py#L248

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have to install the phonenumbers and django-phonenumber-field packages which is what needs to be solved to close #469 if i understand things correctly

'two_factor.plugins.email', # <- for email capability.
'two_factor.plugins.yubikey', # <- for yubikey capability.
]
Expand Down