Conversation
Contributor
|
Hello @Phpvarious, A patch was planned for 4.5.2 but you're right it wasn't suitable. So fixed again 4.5.2 : 1b78dc1 Thank you |
Contributor
Author
|
Hello, Oups, Désolé j'avais pas vu qu'il y avait une branch 4.5.2, Par contre, la proposition dans ton commit ne fonctionne pas si par exemple $_version = 4.5, le retour sera 4.6.0 si je me trompe pas. |
Contributor
|
C'est ce dont je me suis rendu compte avec ta PR ! Voyant que |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lors d'une version majeure, celle-ci est déclaré comme ceci :
https://github.com/jeedom/core/blob/91dd8f73abf2809e4cb0e0abf2986802054535e4/core/config/version
soit 4.5 (au lieu de 4.5.0), et lors d'un update (ex: 4.5.1) cela génère des "Notices" dans le log update :
Je propose donc de forcer le .0 lors qu'il n'est pas présent.
Related issues/external references
Fixes #
Types of changes
PR checklist