Send thumbnail as attachment for Discord #247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Tested in the following scenarios:
|
AllegraCodes
changed the title
Author
|
closing because making http requests from a plugin to the core is obviously not a clean way to do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord webhooks accept embedded thumbnails sent as an attachment to a multipart form, allowing the image to be embedded when the server isn't accessible to the public. Instead of sending just a link to the thumbnail to the webhook, this PR retrieves the image and attaches it to the request sent to the webhook, ensuring it is available. Also update the Item Added template to demonstrate this use.
Fixes #243