Declare precise node to run node-specific tests#3959
Merged
MarkEWaite merged 2 commits intoMay 3, 2026
Merged
Conversation
Busy file systems can be even slower than estimated. I needed an additional 1 second offset when Jenkins core tests were running on the same Linux computer that was testing the git plugin.
Tests may have been passing by accident or luck, since the precise node was not specified and the tests depend on a precise node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declare precise node to run node-specific tests
Tests may have been passing by accident or luck, since the precise node was not specified and the tests depend on a precise node.
Also extends allowed file system offset in test
Busy file systems can be even slower than estimated. I needed an additional 1 second offset when Jenkins core tests were running on the same Linux computer that was testing the git plugin.
Testing done
Confirmed tests pass consistently on my Linux development computer.
Submitter checklist