Skip to content

Declare precise node to run node-specific tests#3959

Merged
MarkEWaite merged 2 commits into
jenkinsci:masterfrom
MarkEWaite:use-correct-node-for-local-checkout-tests
May 3, 2026
Merged

Declare precise node to run node-specific tests#3959
MarkEWaite merged 2 commits into
jenkinsci:masterfrom
MarkEWaite:use-correct-node-for-local-checkout-tests

Conversation

@MarkEWaite
Copy link
Copy Markdown
Contributor

Declare precise node to run node-specific tests

Tests may have been passing by accident or luck, since the precise node was not specified and the tests depend on a precise node.

Also extends allowed file system offset in test

Busy file systems can be even slower than estimated. I needed an additional 1 second offset when Jenkins core tests were running on the same Linux computer that was testing the git plugin.

Testing done

Confirmed tests pass consistently on my Linux development computer.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

MarkEWaite added 2 commits May 3, 2026 13:13
Busy file systems can be even slower than estimated.  I needed an
additional 1 second offset when Jenkins core tests were running on the
same Linux computer that was testing the git plugin.
Tests may have been passing by accident or luck, since the precise node
was not specified and the tests depend on a precise node.
@MarkEWaite MarkEWaite added the tests Automated test addition or improvement label May 3, 2026
@MarkEWaite MarkEWaite requested a review from a team as a code owner May 3, 2026 19:26
@MarkEWaite MarkEWaite merged commit 5712072 into jenkinsci:master May 3, 2026
18 checks passed
@MarkEWaite MarkEWaite deleted the use-correct-node-for-local-checkout-tests branch May 3, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Automated test addition or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant