Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support withCredentials on GitLabApiToken(Impl) #1754

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tiago-teixeira5
Copy link

@tiago-teixeira5 tiago-teixeira5 commented Mar 21, 2025

Fixes #536

Inspired #878 , turns out it was missing the MultiBinding implementation for the GitLabApiTokenImpl class GitLabApiToken interface.

During tests (mvn verify), there was an unexpected failure on GitLabConnectionConfigTest due to my machine having port 80 being listened to. Changing the port to an uncommon port (47 is reserved but apparently not assigned) allowed to circumvent that.

Testing done

A test was added that runs the full pipeline for testing withCredentials, binding with both the full $class and the gitlabApiToken name.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@tiago-teixeira5 tiago-teixeira5 requested a review from a team as a code owner March 21, 2025 07:52
@github-actions github-actions bot added the tests This PR adds/removes/updates test cases label Mar 21, 2025
@tiago-teixeira5 tiago-teixeira5 force-pushed the feature/withCredentials branch from 67704f7 to 3f23564 Compare March 24, 2025 15:06
@krisstern
Copy link
Member

Thanks @tiago-teixeira5! I will give this a review over the next few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests This PR adds/removes/updates test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

withCredentials in pipeline not supported
2 participants