Support withCredentials on GitLabApiToken(Impl) #1754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #536
Inspired #878 , turns out it was missing the
MultiBinding
implementation for theGitLabApiTokenImpl classGitLabApiToken interface.During tests (
mvn verify
), there was an unexpected failure onGitLabConnectionConfigTest
due to my machine having port 80 being listened to. Changing the port to an uncommon port (47 is reserved but apparently not assigned) allowed to circumvent that.Testing done
A test was added that runs the full pipeline for testing
withCredentials
, binding with both the full$class
and thegitlabApiToken
name.Submitter checklist