Skip to content

Ensure urls in widgets loaded via ajax are correct#26721

Open
mawinter69 wants to merge 1 commit into
jenkinsci:masterfrom
mawinter69:issue-26715
Open

Ensure urls in widgets loaded via ajax are correct#26721
mawinter69 wants to merge 1 commit into
jenkinsci:masterfrom
mawinter69:issue-26715

Conversation

@mawinter69
Copy link
Copy Markdown
Contributor

When a widget is reloaded via javascript, the last ancestor is the widget. When inside a view it is then not properly detected that we're inside a view and the links directly go to the item instead via the view.
So in case the last ancestor is a widget we should use the previes ancestor of the widget instead which should normally be the view.

Fixes #26715

Testing done

  1. Create a freestyle or pipeline job that runs for some minutes
  2. Create a view that includes the job
  3. start the job
  4. While in the view wait at least 5 seconds (until the widgets have refreshed)
  5. click on any link in the widget to the job, run or run console (progress bar)
  6. The job/run properly includes the view in the breadcrumb

Screenshots (UI changes only)

Before

After

Proposed changelog entries

  • Ensure urls in widgets loaded via ajax are correct

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

When a widget is reloaded via javascript, the last ancestor is the
widget. When inside a view it is then not properly detected that we're
inside a view and the links directly go to the item instead via the
view.
So in case the last ancestor is a widget we should use the previes
ancestor of the widget instead which should normally be the view.
@comment-ops-bot comment-ops-bot Bot added the bug For changelog: Minor bug. Will be listed after features label Apr 30, 2026
Copy link
Copy Markdown
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite added web-ui The PR includes WebUI changes which may need special expertise labels May 13, 2026
Copy link
Copy Markdown
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process.

/label ready-for-merge

@comment-ops-bot comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 24, 2026
@MarkEWaite MarkEWaite added the ath-successful This PR has successfully passed the full acceptance-test-harness suite label May 24, 2026
@MarkEWaite MarkEWaite added the pct-successful This PR has successfully passed the full plugin-compatibility-test suite label May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ath-successful This PR has successfully passed the full acceptance-test-harness suite bug For changelog: Minor bug. Will be listed after features pct-successful This PR has successfully passed the full plugin-compatibility-test suite ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect breadcrumb/path displayed in Jenkins pipeline view after navigating from dashboard

3 participants