Adjust for experimental Run UI #755
Conversation
janfaracik
force-pushed
the
adjust-for-new-run-ui
branch
from
2605695 to
138145d
Compare
src/main/resources/hudson/tasks/test/AbstractTestResultAction/widget.jelly
Show resolved
Hide resolved
|
Test fix in jenkinsci/jenkins#11219 |
src/main/resources/hudson/tasks/test/AbstractTestResultAction/widget.jelly
Outdated
Show resolved
Hide resolved
src/main/resources/hudson/tasks/test/AbstractTestResultAction/widget.jelly
Outdated
Show resolved
Hide resolved
src/main/resources/hudson/tasks/test/AbstractTestResultAction/widget.jelly
Outdated
Show resolved
Hide resolved
src/main/resources/hudson/tasks/test/AbstractTestResultAction/widget.jelly
Outdated
Show resolved
Hide resolved
| ${it.skipCount} | ||
| </div> | ||
| <j:if test="${it.passCount gt prev.passCount}"> | ||
| <a href="history" |
There was a problem hiding this comment.
This page hasn't been adapted, it still has a sidepanel:
| ${it.passCount} | ||
| </div> | ||
|
|
||
| <j:if test="${it.failCount gt prev.failCount}"> |
There was a problem hiding this comment.
I'm a bit confused on why the history link only shows up conditionally? Fail count could be unrelated tests changing.
There's currently no way to get to the root test history page of the test report as far as I can tell.
There was a problem hiding this comment.
Its odd - I've updated it so history always shows.
| <?jelly escape-by-default='true'?> | ||
| <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:l="/lib/layout" xmlns:p="/prism" xmlns:t="/lib/hudson" xmlns:test="/lib/hudson/test"> | ||
| <l:layout title="${it.displayName} - ${it.run}"> | ||
| <st:include page="sidepanel.jelly" /> |
There was a problem hiding this comment.
not sure where its coming from maybe l:run-subpage but I'm getting the wrong link for Tests in the sidepanel when the experimental flag is disabled.
http://localhost:8089/jenkins/job/junit-attachments-test/view/change-requests/job/PR-2/2/testReport/
If you click on Tests you go to a 404 with testReport nested:
http://localhost:8089/jenkins/job/junit-attachments-test/view/change-requests/job/PR-2/2/testReport/testReport
same if you click from any other sub page to Tests.
There was a problem hiding this comment.
I was able to reproduce it on weekly.ci as well: https://weekly.ci.jenkins.io/job/pipeline/21/testReport/
Likely caused by a refactor for the new build UI as its fine on ci.jenkins.io:
https://ci.jenkins.io/job/Core/job/jenkins/job/master/7882/testReport/
There was a problem hiding this comment.
Fixed now - also spotted the same issue in Pipeline Graph View, opened a PR for it
There was a problem hiding this comment.
LGTM.
just the i18n issue and I'd like to understand what's going on with sidepanel linking:
https://github.com/jenkinsci/junit-plugin/pull/755/files?w=1#r2449728574
2 participants
This PR adds support for the new experimental Run UI, in Jenkins 2.232 onwards. This is currently behind a feature flag, and this plugin supports both legacy and new views.
The interface isn't perfect, but it gives us a good base to build on.
Note: there is a problem with tab ordering, but thats an issue in core - not this plugin.
Testing done
Submitter checklist