Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LabelAction messages for Build and WaitForBuild steps #151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stuartrowe
Copy link
Contributor

@stuartrowe stuartrowe commented Feb 25, 2025

The label for the build step should differentiate between whether the step is waiting for the scheduled build to complete. Similarly the waitForBuild step label should reference the build it's waiting on.

image
image

Testing done

Ran local pipelines that called build with a combination of wait=true, wait=false and waitForStart=true along with calling the waitForBuild step. Confirmed that labels associated with the step nodes was updated accordingly.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@stuartrowe stuartrowe requested a review from a team as a code owner February 25, 2025 06:47
@stuartrowe
Copy link
Contributor Author

@jglick please take a look/tag appropriate reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant