feature : support warnings-ng plugin [JENKINS-57427] #221
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -174,6 +174,41 @@ public enum LifecycleThreshold { | |
| DEPLOY | ||
| } | ||
|
|
||
| public enum TrendChartType { | ||
bguerin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| AGGREGATION_TOOLS, | ||
| TOOLS_AGGREGATION, | ||
| TOOLS_ONLY, | ||
| AGGREGATION_ONLY, | ||
| NONE | ||
| } | ||
|
|
||
| public enum QualityGateType { | ||
bguerin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| TOTAL, | ||
| TOTAL_ERROR, | ||
| TOTAL_HIGH, | ||
| TOTAL_NORMAL, | ||
| TOTAL_LOW, | ||
| TOTAL_MODIFIED, | ||
| NEW, | ||
| NEW_ERROR, | ||
| NEW_HIGH, | ||
| NEW_NORMAL, | ||
| NEW_LOW, | ||
| NEW_MODIFIED, | ||
| DELTA, | ||
| DELTA_ERROR, | ||
| DELTA_HIGH, | ||
| DELTA_NORMAL, | ||
| DELTA_LOW | ||
| } | ||
|
|
||
| public enum QualityGateCriticality { | ||
bguerin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| NOTE, | ||
| UNSTABLE, | ||
| ERROR, | ||
| FAILURE | ||
| } | ||
|
|
||
| public static class Publisher extends PageAreaImpl { | ||
| private final Control disabled = control("disabled"); | ||
|
|
||
|
|
@@ -196,6 +231,19 @@ public static class Publisher extends PageAreaImpl { | |
| private final Control skipDownstreamTriggers = control("skipDownstreamTriggers"); | ||
| private final Control ignoreUpstreamTriggers = control("ignoreUpstreamTriggers"); | ||
|
|
||
| private Control sourceCodeEncoding = control("sourceCodeEncoding"); | ||
|
There was a problem hiding this comment. I would have this page should be generic for all publishers and specific publisher functionality / options should be in a sepearate page area for that Publisher. (e.g. see Credentials -> https://github.com/jenkinsci/acceptance-test-harness/blob/master/src/main/java/org/jenkinsci/test/acceptance/plugins/credentials/StringCredentials.java) |
||
| private Control isEnabledForFailure = control("enabledForFailure"); | ||
| private Control isBlameDisabled = control("skipBlames"); | ||
| private Control trendChartType = control("trendChartType"); | ||
| private Control qualityGateThreshold = control("qualityGateThreshold"); | ||
| private Control qualityGateType = control("qualityGateType"); | ||
| private Control qualityGateCriticality = control("qualityGateCriticality"); | ||
| private Control javaIgnorePatterns = control("javaIgnorePatterns"); | ||
| private Control highPriorityTaskIdentifiers = control("highPriorityTaskIdentifiers"); | ||
| private Control normalPriorityTaskIdentifiers = control("normalPriorityTaskIdentifiers"); | ||
| private Control tasksIncludePattern = control("tasksIncludePattern"); | ||
| private Control tasksExcludePattern = control("tasksExcludePattern"); | ||
|
|
||
| Publisher(final PageArea issuesRecorder, final String path) { | ||
| super(issuesRecorder, path); | ||
| } | ||
|
|
@@ -279,5 +327,65 @@ public Publisher setIgnoreUpstreamTriggers(boolean ignoreUpstreamTriggers) { | |
| this.ignoreUpstreamTriggers.check(ignoreUpstreamTriggers); | ||
| return this; | ||
| } | ||
|
|
||
| public Publisher setSourceCodeEncoding(String sourceCodeEncoding) { | ||
| this.sourceCodeEncoding.set(sourceCodeEncoding); | ||
| return this; | ||
| } | ||
|
|
||
| public Publisher setIsEnabledForFailure(boolean isEnabledForFailure) { | ||
| this.isEnabledForFailure.check(isEnabledForFailure); | ||
| return this; | ||
| } | ||
|
|
||
| public Publisher setIsBlameDisabled(boolean isBlameDisabled) { | ||
| this.isBlameDisabled.check(isBlameDisabled); | ||
| return this; | ||
| } | ||
|
|
||
| public Publisher setTrendChartType(TrendChartType trendChartType) { | ||
| this.trendChartType.select(trendChartType.toString()); | ||
| return this; | ||
| } | ||
|
|
||
| public Publisher setQualityGateThreshold(int qualityGateThreshold) { | ||
| this.qualityGateThreshold.set(qualityGateThreshold); | ||
| return this; | ||
| } | ||
|
|
||
| public Publisher setQualityGateType(QualityGateType qualityGateType) { | ||
| this.qualityGateType.select(qualityGateType.toString()); | ||
| return this; | ||
| } | ||
|
|
||
| public Publisher setQualityGateCriticality(QualityGateCriticality qualityGateCriticality) { | ||
| this.qualityGateCriticality.select(qualityGateCriticality.toString()); | ||
| return this; | ||
| } | ||
|
|
||
| public Publisher setJavaIgnorePatterns(String javaIgnorePatterns) { | ||
| this.javaIgnorePatterns.set(javaIgnorePatterns); | ||
| return this; | ||
| } | ||
|
|
||
| public Publisher setHighPriorityTaskIdentifiers(String highPriorityTaskIdentifiers) { | ||
| this.highPriorityTaskIdentifiers.set(highPriorityTaskIdentifiers); | ||
| return this; | ||
| } | ||
|
|
||
| public Publisher setNormalPriorityTaskIdentifiers(String normalPriorityTaskIdentifiers) { | ||
| this.normalPriorityTaskIdentifiers.set(normalPriorityTaskIdentifiers); | ||
| return this; | ||
| } | ||
|
|
||
| public Publisher setTasksIncludePattern(String tasksIncludePattern) { | ||
| this.tasksIncludePattern.set(tasksIncludePattern); | ||
| return this; | ||
| } | ||
|
|
||
| public Publisher setTasksExcludePattern(String tasksExcludePattern) { | ||
| this.tasksExcludePattern.set(tasksExcludePattern); | ||
| return this; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should not need any argLine at all.
If you need to change a timeout globaly pass
jenkins.test.timeoutas aSystemPropertyto surefire.(arglines are set by the parent pom and can change / add over time if changes are needed.)
Surefire shouldn't need 1GB of RAM for example - The UI tests are not even using
JenkinsRuletype tests but the OSS ATH framework - so timeout here should also be immaterial!?