Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forkCount #422

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Remove forkCount #422

merged 1 commit into from
Jan 25, 2025

Conversation

basil
Copy link
Member

@basil basil commented Jan 25, 2025

Too much parallelism appears to be causing test flakiness.

@basil basil requested a review from a team as a code owner January 25, 2025 15:25
@basil basil merged commit f31e39d into jenkinsci:master Jan 25, 2025
2 of 4 checks passed
@basil basil deleted the forkCount branch January 25, 2025 15:39
@jglick
Copy link
Member

jglick commented Jan 26, 2025

Any particular examples motivating this? I see ExecutorStepTest.restartWhilePlaceholderTaskIsInQueue from a quick search.

@basil
Copy link
Member Author

basil commented Jan 27, 2025

Windows agents were dropping their Remoting connection in CI builds pretty early in the run before this PR. While this PR didn't solve the problem completely, it delayed the disconnections to later in the run and after a few tries I got a run to succeed.

@jglick
Copy link
Member

jglick commented Feb 10, 2025

Hmm. I wonder if this was specific to the VM-based agents. Do you recall if jenkins-infra/pipeline-library#405 (+ jenkins-infra/pipeline-library#436) kicked in?

@basil
Copy link
Member Author

basil commented Feb 10, 2025

I think it has kicked in by now, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants