Skip to content

Fix round #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix round #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b93373
style(round): restructure test with test.each
amoshydra Jan 6, 2025
447fa34
test(round): add more tests, consolidate tests into table and include…
amoshydra Jan 8, 2025
533e0ad
Fix grammar
jessealama Mar 27, 2025
7cd33e9
WIP
jessealama Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Decimal128.mjs.map
View file
Open in desktop

Large diffs are not rendered by default.

29 changes: 19 additions & 10 deletions src/Decimal128.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import {
} from "./common.mjs";
import { Rational } from "./Rational.mjs";
import { Decimal } from "./Decimal.mjs";
import { ROUNDING_MODE_CEILING, ROUNDING_MODE_FLOOR } from "./common.mjs";

const EXPONENT_MIN = -6176;
const NORMAL_EXPONENT_MIN = -6143;
Expand Down Expand Up @@ -96,7 +97,7 @@ function adjustDecimal128(d: Decimal): Decimal128Value {
}

let scaledSig = v.scale10(MAX_SIGNIFICANT_DIGITS - integerPart.length);
let rounded = scaledSig.round(0, "halfEven");
let rounded = scaledSig.isNegative ? scaledSig.negate().roundPositive("halfEven").negate() : scaledSig.roundPositive("halfEven");
let rescaled = rounded.scale10(
0 - MAX_SIGNIFICANT_DIGITS + integerPart.length
);
Expand Down Expand Up @@ -991,19 +992,27 @@ export class Decimal128 {
}

let v = this.cohort() as Rational;
let roundedV = v.round(numDecimalDigits, mode);
let scaledV = v.scale10(numDecimalDigits);

if (roundedV.isZero()) {
return new Decimal128(
new Decimal({
cohort: v.isNegative ? "-0" : "0",
quantum: 0 - numDecimalDigits,
})
);
if (this.isNegative()) {
scaledV = v.negate();
if (mode === ROUNDING_MODE_FLOOR) {
mode = ROUNDING_MODE_CEILING;
} else if (mode === ROUNDING_MODE_CEILING) {
mode = ROUNDING_MODE_FLOOR;
}
}

let roundedScaledV = scaledV.roundPositive(mode);

if (this.isNegative()) {
roundedScaledV = roundedScaledV.negate();
}

let rescaledRoundedV = roundedScaledV.scale10(-numDecimalDigits);

return new Decimal128(
new Decimal({ cohort: roundedV, quantum: 0 - numDecimalDigits })
new Decimal({ cohort: rescaledRoundedV, quantum: 0 - numDecimalDigits })
);
}

Expand Down
Loading