Skip to content

Fix selecting large hunks, and fix problems editing very long commit descriptions #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

stefanhaller
Copy link
Collaborator

See jesseduffield/gocui#80 for details.

Fixes #4470.

@stefanhaller stefanhaller added the bug Something isn't working label May 23, 2025
@stefanhaller
Copy link
Collaborator Author

This is only an "integration branch" for easier testing in lazygit. Code reviews should happen over at jesseduffield/gocui#80.

Copy link

codacy-production bot commented May 23, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 21b8b281
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (21b8b28) Report Missing Report Missing Report Missing
Head commit (5dbd910) 56484 49056 86.85%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4589) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested using the commit message view and it fixes the existing issues

See jesseduffield/gocui#80.

This fixes selecting hunks in the staging view that are longer than the screen.
@stefanhaller stefanhaller force-pushed the fix-selecting-large-hunks branch from f5f4ec1 to 5dbd910 Compare May 29, 2025 12:33
@stefanhaller stefanhaller enabled auto-merge May 29, 2025 12:33
@stefanhaller stefanhaller merged commit c4bfdae into master May 29, 2025
14 checks passed
@stefanhaller stefanhaller deleted the fix-selecting-large-hunks branch May 29, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select hunk (a) broken
2 participants