fix: surface out_of_range error for unsupported HDMI resolution (>1080p) - #1513
Open
nitishagar wants to merge 1 commit into
Open
fix: surface out_of_range error for unsupported HDMI resolution (>1080p)#1513nitishagar wants to merge 1 commit into
nitishagar wants to merge 1 commit into
Conversation
When the HDMI source exceeds 1920x1080, the native layer reports real Width/Height but no Error, so the UI hangs on "Loading video stream...". Classify such states as out_of_range (Ready=false) in OnVideoStateChange before storing/emitting, feeding the existing HDMIErrorOverlay pipeline so the user sees an incompatible-resolution message. rpcGetVideoState reflects the same state for automation. Fixes jetkvm#1482
nitishagar
force-pushed
the
fix/unsupported-hdmi-resolution-error
branch
from
July 2, 2026 08:32
29fc863 to
19e1f8b
Compare
nitishagar
marked this pull request as ready for review
July 2, 2026 08:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the HDMI source resolution exceeds 1920x1080, the native layer reports real
Width/Heightbut leavesErrorempty, so the video state is never classified asout_of_range. The UI then hangs indefinitely on "Loading video stream…" instead of showing the incompatible-resolution error.Fixes #1482
Change
unsupportedResolutionStateinvideo.go: whenError == ""andWidth > 1920 || Height > 1080, setError = "out_of_range"andReady = false.OnVideoStateChangebeforelastVideoStateis stored/emitted, so the existingout_of_range→HDMIErrorOverlaypipeline lights up andrpcGetVideoStatereports the same state for automation.The classification is only applied when no more specific error is already present (
no_signal/no_lockstill win), and it is idempotent.Scope
Testing
TestUnsupportedResolutionState(table-driven): 1920x1080/no-error unchanged; 3840x2160/no-error →out_of_range,Ready=false; existingno_signal/no_lockpreserved.