Support provider-agnostic cloud OIDC tokens - #1533
Open
eekdood wants to merge 3 commits into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the device-side cloud registration/session logic to accept provider-agnostic OIDC fields from the cloud API while preserving compatibility with the existing Google-specific fields.
This pairs with the cloud-api change that makes the OIDC provider configurable. jetkvm/cloud-api#64
Changes
oidcTokenoidcClientIdoidcIssueroidcGoogleclientIdoidc_issueroidc_identitygoogle_identityfor backward compatibility.OidcTokenwhile preservingOidcGoogle.Compatibility
Existing Google-based cloud registrations continue to work through the legacy fields and fallback issuer. This PR intentionally avoids renaming existing Google-specific config fields beyond adding the new provider-agnostic fields, so the behavioral change stays focused and low-risk.
Testing
gofmtgit diff --checknpm run build:device