Force HttpOutput state to CLOSED when ServletContextResponse last write is done
#13894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
sbordet
reviewed
Oct 27, 2025
Contributor
sbordet
left a comment
sbordet
left a comment
There was a problem hiding this comment.
Can you please write a parallel PR where we wrap the response in ResourceServlet to not do the last write, and see what breaks?
Feels more that our model is "wrap if you want to change behavior", and for servlets it appears that we don't want ResourceService to do the last write because the ServletChannel drives it.
So wrapping feels more idiomatic to our programming model.
…849-ServletContextResponse-duplicate-last-write
…849-ServletContextResponse-duplicate-last-write
Contributor
Author
|
Went with #13914 instead. |
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Jetty 12.1.4 - FROZEN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the last write done by the ServletChannel upon completion when the
ResourceServicealready did it via the Core API.Prototype fix for #13849
Also see #13914