Remove LICENSE generation and --FOR-TESTS flag#424
Open
jfmengels wants to merge 2 commits into
Open
Conversation
jfmengels
force-pushed
the
remove-for-tests
branch
from
0da82d2 to
e201eb2
Compare
lishaduck
reviewed
May 11, 2026
| import {glob} from 'tinyglobby'; | ||
| import {$, cd} from 'zx'; | ||
| // @ts-expect-error Warning about using "assert" requiring different "module" value in TS. Haven't figured out how. | ||
| import packageJson from '../package.json' assert {type: 'json'}; |
Contributor
There was a problem hiding this comment.
Assert isn't supported by v16, is it?
Contributor
There was a problem hiding this comment.
Oh, nope, it was backported 👍🏻
Contributor
There was a problem hiding this comment.
Ok, yeah, a ts-expect-error is the best we'll get. TS parses assert the same as with (with some caveats), and is correctly flagging that with is only available in 18+, but we're not using assert. Probably a TS bug but there's also almost certainly not appetite for fixing it at this point.
jfmengels
force-pushed
the
remove-for-tests
branch
from
e201eb2 to
196c181
Compare
Includes removing options.forTests.
jfmengels
force-pushed
the
remove-for-tests
branch
from
196c181 to
b505c4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elm-review new-package, theLICENSEfile will now not be generated automatically. Instead, a manual step has been added in the generatedMAINTENANCE.mdfile.--FOR-TESTSflag and options.forTests.