Skip to content

Conversation

@CrystalENVT
Copy link

No description provided.

@CrystalENVT CrystalENVT force-pushed the main branch 5 times, most recently from 754ea1f to fbe62bf Compare September 7, 2024 21:46
@jgillman
Copy link
Owner

Thanks for the additions, @CrystalSpore! Sorry it's been... years... since you first made this PR.

I'd love to pull in some of your changes but would you mind splitting this into two PRs? It would be easier for me to pull them in and/or comment on changes the PRs were:

  • Dockerization PR (including cron timer job which is related)
  • Changes to get-dns and update-dns scripts

@CrystalENVT
Copy link
Author

Ah sorry, just saw this.

Originally the changes were only to the get-dns & update-dns scripts, & then I later dockerized it for my own use since I wasn't expecting for the PR to ever get merged (due to the extensive time period).

So I should first pr from the commit with the DNS scripts, & then I could make a second PR after the first is merged for the docker components specifically?

@CrystalENVT
Copy link
Author

Made a new PR #2 for just the script components, & I will make another PR for just the docker components.

I can also squash & force push the branch for #2 if you would prefer that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants