Some organization of code #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusting style the line end properly at last element of a branch
|
I made some code re-organization to support noConflict() mode for jquery. |
|
@kumarharsh @jhfrench I have no idea why I haven't seen your replies on this one. Probably I was kinda busy with moving the family between countries. So yes, the main goal is to have a conform registration of the lib in jquery plugin style. This will allow users to use the jquery with noClonflict() (probably nowdays less prototype users are out there but who knows). Probably the style change is something I can revert, that could be a second breaking change in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Organization of the code, to support non-conflict mode of jQuery.
This way is easy to extend the component with more features (like open a branch or find a tree element etc)
Modified the less code, as the vertical line was too long on the last elements.