Conversation
There was a problem hiding this comment.
Pull request overview
このPRは、既存の静的サイト（index.html は維持）を Vite+ ベースの構成へ移行し、今後の修正をしやすくするための土台（依存関係・設定・CI/CD）を追加するものです。
Changes:
- Vite+ / TypeScript / pnpm 構成（
vite.config.ts,tsconfig.json,package.json, lockfile 等）を追加 - 画像など静的アセットを
public/配下で参照できるように追加 - GitHub Actions による PR ビルド（Check）と GitHub Pages へのデプロイ（Deploy）ワークフローを追加
Reviewed changes
Copilot reviewed 6 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
vite.config.ts |
Vite+ の設定を追加 |
tsconfig.json |
Bundler mode 前提の TypeScript 設定を追加 |
package.json |
pnpm + Vite+ 用の scripts / devDependencies を追加 |
pnpm-workspace.yaml |
catalogs/overrides/peerDependencyRules を追加 |
pnpm-lock.yaml |
依存関係をロック |
public/img/* |
静的配信したい画像アセットを追加 |
.github/workflows/deploy.yml |
main push 時の Pages デプロイを追加 |
.github/workflows/check.yml |
PR 時のビルドチェックを追加 |
.gitignore |
Node/Vite 前提の無視設定を追加 |
.vscode/extensions.json |
Vite+ 関連の推奨拡張を追加 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Upload static files as artifact | ||
| uses: actions/upload-pages-artifact@7b1f4a764d45c48632c6b24a0339c27f5614fb0b # v4.0.0 | ||
| with: | ||
| path: dist/ |
There was a problem hiding this comment.
Deploying the built dist/ artifact may drop repository-root files like CNAME unless they’re copied into dist. If this repo relies on the CNAME file for the custom domain, ensure it ends up in dist (e.g., move/duplicate it into public/ so Vite copies it, or configure the Pages deploy step accordingly).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 23 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| vite: npm:@voidzero-dev/vite-plus-core@latest | ||
| vitest: npm:@voidzero-dev/vite-plus-test@latest | ||
| vite-plus: latest |
There was a problem hiding this comment.
The workspace catalog/overrides use @latest (e.g. npm:@voidzero-dev/vite-plus-core@latest). This makes dependency resolution non-deterministic whenever the lockfile is regenerated (or when installing without --frozen-lockfile), which can introduce breaking changes unexpectedly. Consider pinning to a known-good version range (or at least a specific minor/patch) and updating intentionally.
| vite: npm:@voidzero-dev/vite-plus-core@latest | |
| vitest: npm:@voidzero-dev/vite-plus-test@latest | |
| vite-plus: latest | |
| vite: npm:@voidzero-dev/vite-plus-core@1.0.0 | |
| vitest: npm:@voidzero-dev/vite-plus-test@1.0.0 | |
| vite-plus: 1.0.0 |
There was a problem hiding this comment.
デフォルトの出力がこうだったため一旦このまま行きたいです
nabe1005
left a comment
nabe1005
left a comment
There was a problem hiding this comment.
問題なさそうです。LGTM!
バージョン指定がlatestなのがセキュリティ的に問題ないかは気にしておきたいところかなと思いました
|
https://www.npmjs.com/package/@voidzero-dev/vite-plus-core まだバージョンが v0 台なのでアップデートが頻繁なので latest なのかもですね。様子見ながら必要に応じて対応します 🙏 |
今後のページ修正に向けて、スムーズに移行するための下準備になります
変更点
index.htmlはそのまま変更無し起動方法
開発用：
pnpm devビルド：
pnpm buildビルドしたもののプレビュー：
pnpm preview備考
現状維持で見た目を変えずにデプロイ方法だけを Vite 使ったものに変えたかったため、
index.htmlはそのまま使っています。