Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
||
| 2. **Concurrency safety review** — Both `writeAutoMemoryWatermark()` and `writeCronWatermark()` wrote to shared state (`~/.claude/cache/`) without advisory file locks, violating the CLAUDE.md convention. Fixed by wrapping both in `withFileLock()` consistent with the registry write pattern. | ||
|
|
||
| The PR was already merged before these review fixes were pushed, so the two fix commits (258e918, 9dc4fe6) landed on the branch after merge. |
There was a problem hiding this comment.
Incorrect chronology — these commits landed before the merge, not after.
Both 258e918 and 9dc4fe6 were committed ~2.5 hours before PR #45 was merged and were included in the merge:
258e918→2026-04-09T07:44:27Z9dc4fe6→2026-04-09T08:01:59Z- PR feat: auto-memory interop with assist/takeover modes #45 merged →
2026-04-09T10:27:55Z
The same incorrect statement is repeated in the Gotchas section (line 105). This inverted timeline could mislead a future session into thinking the review fixes were not included in the merged PR — when in fact they were already merged.
See:
memex-claude/.claude/handoffs/20260409-auto-memory-interop-merged.md
Lines 18 to 20 in b6efdb9
| 9dc4fe6 fix: wrap watermark writes in withFileLock for concurrency safety | ||
| 258e918 fix: centralize autoMemoryWatermarkPath in paths.ts per review feedback | ||
| bbe9b22 fix: handle compiled binary path in getPluginRoot | ||
| a1caac7 fix: combine takeover + sleep schedule sections instead of early return | ||
| 1194005 docs: document autoMemoryMode config key |
There was a problem hiding this comment.
Git log snapshot is stale — missing the actual PR #45 head commit.
The log shows 9dc4fe6 as HEAD, but the real headRefOid of PR #45 is 01019cd ("Update src/hooks/session-start.ts"), which sits on top of 9dc4fe6. This commit moved mkdir(dirname(watermarkPath), { recursive: true }) from inside the withFileLock() callback to before it in writeCronWatermark() — a meaningful ordering fix, since acquiring the lock requires the directory to already exist.
The Review feedback addressed section (lines 42-43) is also incomplete for the same reason — it lists only 258e918 and 9dc4fe6 but omits 01019cd.
See:
memex-claude/.claude/handoffs/20260409-auto-memory-interop-merged.md
Lines 58 to 66 in b6efdb9
Summary
End-of-session assets generated by
/wrap-things-up:Generated by
/wrap-things-upskill — automated end-of-session workflow.🤖 Generated with Claude Code
Summary by cubic
Adds an end-of-session handoff document to
.claude/handoffs/20260409-auto-memory-interop-merged.mdsummarizing the merged auto-memory interop work (assist/takeovermodes), key decisions, and remaining manual tests. Improves session continuity and makes it easy to resume verification.Written for commit b6efdb9. Summary will update on new commits.